Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Daily Update Velox Version (2024_03_21) #5064

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[VL] Daily Update Velox Version (2024_03_21) #5064

merged 2 commits into from
Mar 21, 2024

Conversation

GlutenPerfBot
Copy link
Contributor

Upstream Velox's New Commits:

64f9618c3 by Wei He, Fix exception thrown in custom result verifier in WindowFuzzer (9189)
3db2a9ad8 by Nicholas Ormrod, Deshim //folly:dynamic to //folly/json:dynamic in velox (8931)
43a552715 by Sergey Pershin, Add Task:driverCounts() (9166)
7e8105a0b by rui-mo, Fix gatherFromTimestampBuffer (9170)
5186d0bc9 by joey.ljy, Fix the CMakeLists.txt to sort the cpp files in alphabetical order (9164)
6f09b8fe5 by Richard Barnes, Remove unused exception parameter from velox/common/base/tests/StatusTest.cpp (9180)
b8c752abc by Richard Barnes, Enable `-Wmismatched-tags` in velox/PACKAGE (9181)
2c044edfc by Richard Barnes, Remove unused variables in velox/tpch/gen/dbgen/text.cpp (9142)
e574117a4 by Richard Barnes, Remove unused variables in velox/connectors/hive/tests/HiveDataSinkTest.cpp
f99cf2858 by Masha Basmanova, Extract CppToType and CastTypeChecker from Type.h (9161)
491c46fa3 by Krishna Pai, Fix build on ubuntu and gcc 11 (9163)
469e2da6c by Jacob Wujciak-Jens, Move Linux build, adapters and presto fuzzer to gha (8734)
443c72dc2 by joey.ljy, Unregister the UDTs after use in ArrayViewTest and ArrayWriterTest (9175)
35fd4b757 by Ma, Rong, Add make_ym_interval Spark function (8887)
fe0c1fd52 by Jialiang Tan, Threshold based spilling removal (9069)
07d638c1b by 8dukongjian, Fix regr_r2 failure in AggregationFuzzer (9173)
8981498a9 by Masha Basmanova, Replace fromKindToScalerType with createScalarType (9162)
cd2523fac by Kevin Wilfong, Fix hang in MultiThreadedTaskCursor when Task fails (9134)
5e077909f by xiaoxmeng, Table scan cleanup (9156)
21491d74a by Kevin Wilfong, Fix NPE caused by testingRunArbitration (9137)
1d95a474a by Kevin Wilfong, Fix bug in PrestoVectorSerializers when serializing empty Vectors with complex types (9157)
29d0f317d by Wei He, Fix window fuzzer test (9153)

@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@yma11
Copy link
Contributor

yma11 commented Mar 21, 2024

/Benchmark Velox

3 similar comments
@yma11
Copy link
Contributor

yma11 commented Mar 21, 2024

/Benchmark Velox

@yma11
Copy link
Contributor

yma11 commented Mar 21, 2024

/Benchmark Velox

@yma11
Copy link
Contributor

yma11 commented Mar 21, 2024

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5064_time.csv log/native_master_03_20_2024_e1f0c01a7_time.csv difference percentage
q1 36.00 38.53 2.521 107.00%
q2 23.52 24.00 0.474 102.02%
q3 36.87 37.50 0.630 101.71%
q4 37.02 38.61 1.590 104.29%
q5 69.11 71.63 2.520 103.65%
q6 7.28 7.37 0.082 101.12%
q7 84.38 83.96 -0.422 99.50%
q8 86.30 84.46 -1.843 97.86%
q9 122.45 125.15 2.697 102.20%
q10 43.89 45.58 1.688 103.85%
q11 20.44 20.52 0.081 100.40%
q12 27.03 28.80 1.775 106.57%
q13 47.78 48.70 0.921 101.93%
q14 21.26 22.25 0.984 104.63%
q15 31.10 31.14 0.038 100.12%
q16 13.54 15.42 1.883 113.91%
q17 103.26 102.47 -0.787 99.24%
q18 143.56 143.60 0.039 100.03%
q19 15.10 13.64 -1.461 90.32%
q20 29.24 27.02 -2.221 92.41%
q21 224.17 225.52 1.348 100.60%
q22 16.56 13.96 -2.601 84.30%
total 1239.87 1249.81 9.934 100.80%

@zhouyuan
Copy link
Contributor

note: the cap based spill is removed

@zhouyuan zhouyuan merged commit f51b7ab into apache:main Mar 21, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyuan zhouyuan zhouyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GlutenPerfBot @yma11 @zhouyuan